Changeset bc97cd8 in nscp for modules/CheckEventLog/CheckEventLog.cpp

Timestamp:

09/06/08 20:51:13 (5 years ago)

Author:

Michael Medin <michael@…>

Branches:

master, 0.4.0, 0.4.1, 0.4.2, stable

Children:

dc59b0e

Parents:

c0522cd

Message:

2008-09-06 MickeM

• Improved error reporting in the eventlogchecker
• *BREAKING CHANGE* filter=new is now the default so unless you use the new filtering you need to specify filter=old instead! I Recommend everyone to stop using the "old" filtering.

2008-09-04 MickeM

• Fixed issues with new service stuff on NT4 and W2K (should work fine now) + Added some DebugOutput? to service handling features so if you experience tropubel try using sysinternals DebugView? too se logging before the agent startes.
• Fixed a memory leak in the error formating code

2008-08-24 MickeM

• Changed NSCA "general problem" error message to be more descriptive.
• Fixed issue with CheckCPU not returning a valid performance unit (%) see issue #219 for details.

File:

• modules/CheckEventLog/CheckEventLog.cpp (modified) (3 diffs)

modules/CheckEventLog/CheckEventLog.cpp

@@ -405 +405 @@
   bool bFilterIn = true;
   bool bFilterAll = false;
-  bool bFilterNew = false;
+  bool bFilterNew = true;
   bool bShowDescriptions = false;
   bool unique = false;
@@ -471 +471 @@
 
   unsigned long int hit_count = 0;
+  if (files.empty()) {
+    message = _T("No file specified try adding: file=Application");
+    return NSCAPI::returnUNKNOWN;
+  }
 
   for (std::list<std::wstring>::const_iterator cit2 = files.begin(); cit2 != files.end(); ++cit2) {
@@ -502 +506 @@
 
         if (filter_chain.empty()) {
-          message = _T("No filters specified.");
+          message = _T("No filters specified try adding: filter+generated=>2d");
           return NSCAPI::returnUNKNOWN;
         }