Changeset dff5db9 in nscp for include

Timestamp:

06/15/08 14:09:36 (5 years ago)

Author:

Michael Medin <michael@…>

Branches:

master, 0.4.0, 0.4.1, 0.4.2, stable

Children:

e1ef872

Parents:

8f167e8

Message:

2008-06-14 MickeM

• Fixed error message from external commands (better reporting now)

2008-05-14 MickeM

• Fixed memoryleak in the service checker.

I am really sorry I usualy write better code then this.

Location:

include

Files:

• config.h (modified) (1 diff)
• execute_process.hpp (modified) (1 diff)

include/config.h

@@ -26 +26 @@
 
 // Version
-#define SZBETATAG _T(" ") // _T(" RC ")  _T(" BETA ") 
+#define SZBETATAG _T(" RC ")  //_T(" ") // _T(" RC ")  _T(" BETA ") 
 #define SZVERSION STRPRODUCTVER SZBETATAG STRPRODUCTDATE
 //FILEVER[0]

include/execute_process.hpp

@@ -144 +144 @@
       CloseHandle(hChildOutR);
     } else {
-      msg = _T("NRPE_NT failed to create process (") + command + _T("): ") + error::lookup::last_error();
+      DWORD error = GetLastError();
+      if (error == ERROR_BAD_EXE_FORMAT) {
+        NSC_LOG_ERROR_STD(command + _T(" is not an .exe file or a valid image (if you run a script you usually need to prefix the command with the interpreter like so: \"command=c:\perl.exe <script>\""));
+        msg = _T("ExternalCommands: failed to create process (") + command + _T("): it is not an exe file (check NSC.log for more info) - ") + error::lookup::last_error(error);
+      } else {
+        msg = _T("ExternalCommands: failed to create process (") + command + _T("): ") + error::lookup::last_error(error);
+      }
       result = NSCAPI::returnUNKNOWN;
       CloseHandle(hChildInR);