Opened 5 years ago

Closed 5 years ago

#188 closed defect (fixed)

CheckDriveSize: CheckAllOthers doesn't work without trailing backslash on drive path

Reported by: Jeff Goldschrafe <goldschr@…> Owned by: MickeM
Priority: 1 Milestone: 0.3.3
Component: Core Module Version: 0.3.2
Severity: Bugs Keywords:
Cc:

Description

CheckAllOthers? doesn't work unless the trailing backslash is appended to the specified drive letters -- it continues to check the drives named. Normal drive checks (e.g. without CheckAllOthers?) do not have this behavior.

Attachments (2)

NSClient++-CheckDisk-CheckAllOthers-FixTrailingSlashProblem.patch​ (1.2 KB) - added by Jeff Goldschrafe <goldschr@…> 5 years ago.
Function to compare drive names for equality; currently strips trailing slashes and backslashes
NSClient++-CheckDisk-CheckAllOthers-FixTrailingSlashProblem.2.patch​ (1.2 KB) - added by Jeff Goldschrafe <goldschr@…> 5 years ago.
Actually getting your logic tests right is a pretty good idea

Download all attachments as: .zip

Change History (4)

comment:1 Changed 5 years ago by anonymous

  • Component changed from Core to Core Module

Changed 5 years ago by Jeff Goldschrafe <goldschr@…>

Function to compare drive names for equality; currently strips trailing slashes and backslashes

Changed 5 years ago by Jeff Goldschrafe <goldschr@…>

Actually getting your logic tests right is a pretty good idea

comment:2 Changed 5 years ago by mickem

  • Milestone changed from 0.4.0 to 0.3.3
  • Resolution set to fixed
  • Status changed from new to closed

LOL, should have refresh before I fixed this :)

anyways fixed in latest nightly :)
(though your solutions was prettier, mines a hack)

I also noticed that this is pretty dated code and I think we should add support for volumes instead of using "dos drive letters"...

MickeM

Note: See TracTickets for help on using tickets.