> 3.8 perfdata wrong

[Ruddimaster]

Hi,
the perfdata are on 3.8 and above works not with PNP if the thresholds are not in percent.

./check_nrpe -H 1.2.3.4 -t 30 -p 5666 -c CheckDriveSize -a CheckAllOthers? MinWarnFree?=1G MinCritFree?=500M Drive=C: Drive=Y: Drive=X:

OK: All drives within bounds.|'D:\ %'=32%;96;98; 'D:\'=16805.57M;1024;500;0;24483.96; 'E:\ %'=28%;100;100; 'E:\'=251212.61M;1024;500;0;347274.12; 'F:\ %'=79%;98;99; 'F:\'=7310.11M;1024;500;0;34726.4;

[andrucha]

hi, if the thresholds are in percent, the perfdata are wrong too. For example:

check_nrpe -H 1.2.3.4 -c check_disk_c

Alias: check_disk_c=CheckDriveSize MaxWarnUsed?=90% MaxCritUsed?=95% c

Output: OK: All drives within bounds.|'c: %'=77%;90;95 'c:'=23685.47MB;3077.26;517.55;0;30725.84

3077.26 is not 90% from 30725.84 and
517.55 is not 95% from 30725.84

Example #2:
./check_nrpe -H 172.30.96.17 -c check_disk_c_free

Alias: check_disk_c_free=CheckDriveSize MinWarnFree?=10% MinCritFree?=5% c

Output: OK: All drives within bounds.|'c: %'=23%;10;5 'c:'=23.1GB;3.00;1.;0;30.00

"1." is not 5% from "30.00"

The version 3.9 rc1 is affected too.

[mickem]

Ahh... there is a missing 0 there... right, lets see if I can dig up why...

Michael Medin

[andrucha]

I think there is some more wrong as missing 0.

In example 1: check_disk_c=CheckDriveSize MaxWarnUsed?=90% MaxCritUsed?=95% c

'c: %'=77%;90;95 'c:'=23685.47MB;3077.26;517.55;0;30725.84

23685.47 is 77% from 30725.84
3077.26 is NOT 90% from 30725.84, should be 27653,256
517.55 is NOT 95% from 30725.84, should be 29189,548

In example 2: check_disk_c_free=CheckDriveSize MinWarnFree?=10% MinCritFree?=5% c

'c: %'=23%;10;5 'c:'=23.1GB;3.00;1.;0;30.00

here is something wrong between 'free' and 'used'

prfdata here is a mix between used (23.1GB) and free (3.00;1) space.

It would be very nice if you could check it.

Thank you.

[mickem]

Fixed in the next RC (out in a bit)

MickeM