CheckDriveSize, perfdatas

[benoitp]

Hello,

Something has changed in perfdata of CheckDriveSize in the last releases.

0.3.7 :
Performance Data 'C:'=64%;5;2;

0.3.9
Performance Data 'C: %'=45%;5;2 'C:'=11324.53MB;1018.85;407.54;0;20377

It would be nice if the module only give % perfdata if we give threshold in %.
And only give perfdata in Bytes if we give threshold in bytes.

Same behavior with «CheckMem», and i'm sure more modules.

Regards.

[mickem]

Yes, this is unfortunate but the previous syntax was problematic as it had same labels on different things (ie. % as well as B so if you want both you run into troubles).

A future version will allow this to be configure but nothing in the near term...
If this is is a big issue I could maybe add some flag to allow backwards compatible syntax?

Michael Medin

[benoitp]

Changes

[benoitp]

I will try to show you exactly what are the consequences of this behavior with a picture (please look at the file i just attached to this ticket).

With only one perfdata, when we build a graph the scale is easy to setup and the curve is well drawn, as shown on the picture with NSClient 0.3.7.

With 2 perfdata, as different as % of free space, and free bytes, the scale can't be consistent. For %, the scale must be «100» and for the free space it must be far greater. (look the 2nd graph, you can't see the top of the curve for «C: MB»

So, the best thing is to be configurable, but for sure, a flag for backwards compatibility can do the trick while waiting the new feature.

Regards.

[mickem]

Humm...

But that should be just "re-create the graph" (and/or update the name) right?

But Ill look into adding something then...

Michael Medin

[mickem]

re-targeting to 0.4.2