LocalSystem Services should use quoted executable paths

[steffenpoulsen]

Recently a security audit showed that the NSClient service is configured with an unquoted executable path:

BINARY_PATH_NAME=c:\Program Files\NSClient\NSClient++.exe

This should be changed so that NSClient instead will register the service using a quoted executable path, e.g.:

BINARY_PATH_NAME="c:\Program Files\NSClient\NSClient++.exe"

---

Some background information ("The Program.exe hack").

​http://www.ihtb.org/security/program.exe-privilege_escalation.txt
​http://seclists.org/fulldisclosure/2007/Aug/492
​http://cwe.mitre.org/data/definitions/428.html
​http://msdn.microsoft.com/en-us/library/xe736fyk(v=vs.71).aspx

[mickem]

This is if nothing else fixed (I think) in 0.4.0 which installed as:

"C:\Program Files\NSClient++\nscp.exe" --service --run --name nscp

But maybe I should do an updated 0.3.9 as well?

Michael Medin

[steffenpoulsen]

Ah, that sounds great, that it is already fixed in 0.4.0!

If it is not too much work I would appreciate an updated 0.3.9 very much :-)

[mickem]

Setting this to resolved as there most likely wont be a 3.10 version (and it is fixed in 0.4.0 anyways)