CheckDriveSize returns wrong warn/crit values in performance data

[birkes]

May be related to #546

check_nrpe -H host -p 5666 -c CheckDriveSize -a MinWarnFree=10G MinCritFree=5G Drive=E:

returns

OK: All drives within bounds.|'E: %'=45%;78;89 'E:'=26.53GB;2;1;0;47.39

I would expect

OK: All drives within bounds.|'E: %'=45%;78;89 'E:'=26.53GB;10;5;0;47.39

[mickem]

Interesting,

Does 0.4.0 have the same behavior?

Michael Medin

[mickem]

This will be resolved in next build of 0.4.1

[birkes]

Replying to mickem:

Interesting,

Does 0.4.0 have the same behavior?

Michael Medin

If I can get 0.4.0 working on my test system I'll let you know

[mickem]

Well, it does... this is code which has not changed...

If you can verify the fix in 0.4.1 I will patch 0.4.0 as well... 0.3.9 is doubtful as that requires a lot more work, but I guess it could be done in a pinch...

Michael Medin

[birkes]

Finally got my config to work. Bug is present in 0.4.0. Will check latest 0.4.1

[mickem]

BTW, if you had issue with the config going to 0.4.0 please let me know so I can resolve the conversions...

Michael Medin

[birkes]

Replying to mickem:

BTW, if you had issue with the config going to 0.4.0 please let me know so I can resolve the conversions...

Michael Medin

The default sections were ok with --migrate-to but I have some selfmade powershell scripts which result in a "UNKNOWN: No handler for that command." now
The new config looks like this:

[/settings/external scripts/scripts/check_powershell_HDD]
; check_powershell_HDD - Alias for check_powershell_HDD. To configure this item add a section called: /settings/external scripts/scripts/check_powershell_HDD

check_powershell_HDD = powershell.exe -NoLogo -InputFormat none -NoProfile -NonInteractive -command "& {scripts\check_powershell_HDD.ps1 $ARG1$;exit $Env:HDD}"

[/settings/external scripts/scripts/check_powershell_eventlog]
; check_powershell_eventlog - Alias for check_powershell_eventlog. To configure this item add a section called: /settings/external scripts/scripts/check_powershell_eventlog

check_powershell_eventlog = powershell.exe -NoLogo -InputFormat none -NoProfile -NonInteractive -command "& {scripts\check_powershell_eventlog.ps1 $ARG1$;exit $Env:EventLogStatus}"

The debug output from the console looks like this:

d ver\handler_impl.cpp:34   Running command: check_powershell_HDD
d ver\handler_impl.cpp:36   Running command: CheckTaskSched = OK: All scheduled tasks are good.
d rvice\NSClient++.cpp:923  Injecting: check_powershell_hdd...
d erver\connection.cpp:106  Wrote data: 1036
d erver\connection.cpp:51   Timeout reading: 1024
d erver\connection.cpp:37   starting data connection
d pe\server\server.cpp:95   Accepting connection from: ::ffff:xxx.xxx.xxx.xxx
d rvice\NSClient++.cpp:948  Result check_powershell_hdd: BAD_CODE: -1
d ver\handler_impl.cpp:34   Running command: check_powershell_HDD
d r\ssl_connection.cpp:27   starting secure data connection
e api_core_wrapper.cpp:181  No handler for command 'check_powershell_HDD'.
d rvice\NSClient++.cpp:923  Injecting: check_powershell_hdd...
d erver\connection.cpp:37   starting data connection
d ver\handler_impl.cpp:36   Running command: check_powershell_HDD =
d rvice\NSClient++.cpp:948  Result check_powershell_hdd: BAD_CODE: -1
d ver\handler_impl.cpp:34   Running command: checkDriveSize
d erver\connection.cpp:51   Timeout reading: 1024
d erver\connection.cpp:106  Wrote data: 1036
e api_core_wrapper.cpp:181  No handler for command 'check_powershell_HDD'.
d rvice\NSClient++.cpp:923  Injecting: checkdrivesize...
d ver\handler_impl.cpp:36   Running command: check_powershell_HDD =
d rvice\NSClient++.cpp:948  Result checkdrivesize: OK
d erver\connection.cpp:106  Wrote data: 1036
d erver\connection.cpp:51   Timeout reading: 1024